Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readASD #2

Open
l-ramirez-lopez opened this issue Mar 17, 2020 · 3 comments
Open

readASD #2

l-ramirez-lopez opened this issue Mar 17, 2020 · 3 comments

Comments

@l-ramirez-lopez
Copy link
Owner

further update the readASD function for full compatibility with v8 files (re-organize it)

@pierreroudier
Copy link

Hey @l-ramirez-lopez ,

Just bringing your attention to our asdreader package -- which sole and only purpose is to precisely read ASD files.

Happy to get you on-board if you want to contribute to the package, and use it within prospectr, as I'm concerned of duplicated efforts.

Let me know what you think!

@l-ramirez-lopez
Copy link
Owner Author

Hi Pierre,
Sounds a really good idea. I'll be happy to contribute.
I see your package appears to have one minor issue reported (which might be not even an actual bug). So please let me know how you think I can contribute.

@pierreroudier
Copy link

I see your package appears to have one minor issue reported (which might be not even an actual bug).

Yes, we have this issue open for about 2 years, because I can't reproduce it. It sounds like a limitation of Windows (hard limit on the number of files open?).

So please let me know how you think I can contribute.

The asdreader package works well as is, so I'm sure you know, most of the work is un-glamourous maintenance! I think something very valuable would be to:

  1. Ensure we have the same features as your readASD function.
  2. Ensure the different versions of ASD files are supported -- a very useful addition would be some unit testing specifically on this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants