Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exportloopref may be able to check decendants member like a.b.c.d... #5

Closed
kyoh86 opened this issue Jun 25, 2020 · 0 comments · Fixed by #6
Closed

exportloopref may be able to check decendants member like a.b.c.d... #5

kyoh86 opened this issue Jun 25, 2020 · 0 comments · Fixed by #6
Assignees
@kyoh86
Labels
enhancement New feature or request

Comments

@kyoh86
Copy link
Owner

kyoh86 commented Jun 25, 2020

#2 is the problem that when a parent of Selector (i.e. a of the a.b) is the pointer, exportloopref reports false-positive.

In past, I thought that exportloopref cannot report &a.b.c.d since it cannot check each of the layer in the Selectors is not a pointer.
But now, I found the solution ( *analysis.Pass.TypeInfo ).
So maybe I can check that.
@kyoh86 kyoh86 added the enhancement New feature or request label Jun 25, 2020
@kyoh86 kyoh86 self-assigned this Jun 25, 2020
@kyoh86 kyoh86 mentioned this issue Jun 25, 2020
Merged
@kyoh86 kyoh86 closed this as completed in #6 Jun 25, 2020
@kyoh86 kyoh86 reopened this Jun 25, 2020
@kyoh86 kyoh86 closed this as completed in 5595d7c Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyoh86 kyoh86

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore when ranging over a slice of pointers kyoh86/exportloopref
1 participant
@kyoh86