Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct Runtime status in Compass Director after successfully registering it #126

Open
koala7659 opened this issue Mar 1, 2024 · 2 comments
Assignees
Labels
area/control-plane Related to all activities around Kyma Control Plane

Comments

@koala7659
Copy link
Contributor

koala7659 commented Mar 1, 2024

After Kyma Runtime is successfully registered in Director, we should use UpdateRuntime mutation to mark it as Connected.
Now the status is permanent in Initial state.

You can reuse code from SetRuntimeStatusCondition method in Director interface from provisioner.

Available states are:

const (
    RuntimeStatusConditionInitial      RuntimeStatusCondition = "INITIAL"
    RuntimeStatusConditionProvisioning RuntimeStatusCondition = "PROVISIONING"
    RuntimeStatusConditionConnected    RuntimeStatusCondition = "CONNECTED"
    RuntimeStatusConditionFailed       RuntimeStatusCondition = "FAILED"
)

We should also set following labels in compass for the runtime when the cluster domain is assigned

	runtime.Labels["gardenerClusterName"] = shoot.Name
	runtime.Labels["gardenerClusterDomain"] = *shoot.Spec.DNS.Domain

Alternate solution : We can consider moving this code to Compass Runtime Agent since the Runtime is really connected as soon the agent downloads certificates from Director and the CompassConnector CR on SKR is set to Synchronized state.

Depends on
kyma-project/application-connector-manager#48

@koala7659 koala7659 added the area/control-plane Related to all activities around Kyma Control Plane label Mar 1, 2024
@koala7659 koala7659 self-assigned this Mar 1, 2024
@koala7659 koala7659 changed the title Set correct Runtime status in Director after successfully registering it Set correct Runtime status in Compass Director after successfully registering it Mar 1, 2024
@mvshao
Copy link
Contributor

mvshao commented Mar 1, 2024

@koala7659 If Compass Runtime Agent has a Director client it could be an excellent idea to move setting Connected status to it. But are there any drawbacks regarding this idea?

@m00g3n m00g3n assigned akgalwas and unassigned koala7659 Mar 14, 2024
@akgalwas
Copy link
Contributor

It was agreed that the status will be set by the Compass Runtime Agent. Here is the PR: kyma-project/kyma#18623 .

@koala7659 koala7659 self-assigned this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane
Projects
None yet
Development

No branches or pull requests

3 participants