Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.3.dev7 breaks list support #3083

Closed
bigluck opened this issue Mar 19, 2024 · 1 comment
Closed

v0.3.3.dev7 breaks list support #3083

bigluck opened this issue Mar 19, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bigluck
Copy link

bigluck commented Mar 19, 2024

I am currently using this query as a workaround for the issue reported on #3054:

conn.execute(
    query = "MERGE (n:MyTable { id: $id }) SET n.name = $name, n.scan_columns = [\"driver_name\", \"hvfhs_license_num\", \"request_datetime\"], n.scan_filter = $scan_filter, n.scan_limit = $scan_limit RETURN n.id",
    params: {
        "name": "taxi_fhvhv",
        "scan_filter": "NOT driver_name IS NULL AND request_datetime < '2023-01-10T00:00:00-05:00' AND request_datetime >= '2022-01-01T00:00:00-05:00'",
        "scan_limit": 5,
        "id": "56d0ea9d74b2143d10cc4ad05e4ba4aac8a75654b51c5691d5a56f8f97b567dc"
    }
)

but starting from v0.3.3.dev7 one of my certification tests fail:

    expected_node: {'_id': {'offset': 5, 'table': 41},
                    '_label': 'MyTable',
                    'artifact_name': 'taxi_fhvhv',
                    'scan_columns': None,
                    'scan_filter': 'NOT driver_name IS NULL AND request_datetime < '
                                   "'2023-01-10T00:00:00-05:00' AND request_datetime >= "
                                   "'2022-01-01T00:00:00-05:00'",
                    'scan_id': '56d0ea9d74b2143d10cc4ad05e4ba4aac8a75654b51c5691d5a56f8f97b567dc',
                    'scan_limit': 5}
    test_node: {'artifact_name': 'taxi_fhvhv',
                'scan_columns': ['driver_name', 'hvfhs_license_num', 'request_datetime'],
                'scan_filter': 'NOT driver_name IS NULL AND request_datetime < '
                               "'2023-01-10T00:00:00-05:00' AND request_datetime >= "
                               "'2022-01-01T00:00:00-05:00'",
                'scan_id': '56d0ea9d74b2143d10cc4ad05e4ba4aac8a75654b51c5691d5a56f8f97b567dc',
                'scan_limit': 5}
    exc: AssertionError('Expected "scan_columns" to be [\'driver_name\', \'hvfhs_license_num\', \'request_datetime\'] but got None')

After switching back to v0.3.3.dev1, the test passed without any segmentation fault, unlike the other most recent versions.

@ray6080 ray6080 added the bug Something isn't working label Mar 19, 2024
@ray6080 ray6080 self-assigned this Mar 19, 2024
@ray6080
Copy link
Contributor

ray6080 commented Mar 26, 2024

This is now fixed after the var list layout rework #3093.

@ray6080 ray6080 closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants