Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataTypeInfo from codebase #2423

Closed
acquamarin opened this issue Nov 16, 2023 · 0 comments · Fixed by #2539
Closed

Remove DataTypeInfo from codebase #2423

acquamarin opened this issue Nov 16, 2023 · 0 comments · Fixed by #2539
Assignees

Comments

@acquamarin
Copy link
Collaborator

struct DataTypeInfo {
public:
    DataTypeInfo(common::LogicalTypeID typeID, std::string name)
        : typeID{typeID}, name{std::move(name)}, numValuesPerList{0} {}

    common::LogicalTypeID typeID;
    std::string name;
    std::vector<std::unique_ptr<DataTypeInfo>> childrenTypesInfo;
    // Used by fixedList only.
    uint64_t numValuesPerList;

    static std::unique_ptr<DataTypeInfo> getInfoForDataType(
        const common::LogicalType& type, const std::string& name);
};

We should remove this class and use LogicalType, columnNames directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants