Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark Docker Node Installation Deprecation #2021

Closed
Riolku opened this issue Sep 11, 2023 · 2 comments
Closed

Benchmark Docker Node Installation Deprecation #2021

Riolku opened this issue Sep 11, 2023 · 2 comments

Comments

@Riolku
Copy link
Contributor

Riolku commented Sep 11, 2023

image

The script we use to install node in the benchmark docker container is deprecated, we need to replace it.

@mewim
Copy link
Member

mewim commented Sep 12, 2023

This seems to be a very recent change. The benchmark container actually does not require Node.js so we can remove the Node.js installation steps. The test container needs Node.js though and we need to migrate the script.

@Riolku Riolku closed this as completed Nov 13, 2023
@Riolku
Copy link
Contributor Author

Riolku commented Nov 13, 2023

Done in #2163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants