Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion failed when importing CSV with string list #1352

Closed
rfdavid opened this issue Mar 6, 2023 · 6 comments
Closed

Assertion failed when importing CSV with string list #1352

rfdavid opened this issue Mar 6, 2023 · 6 comments
Assignees

Comments

@rfdavid
Copy link
Collaborator

rfdavid commented Mar 6, 2023

To benchmark #1327 for string list, I created the following node table and imported a CSV with randomly generated values:

CREATE NODE TABLE Preference(name STRING, pref STRING[], PRIMARY KEY (name));

When trying to match the list, I'm getting an assertion failed:

➜  shell git:(master) ./kuzu_shell -i db
Opened the database at path: db
Enter ":help" for usage hints.
kuzu> match (p:Preference) return p.pref;
Assertion failed: (srcEndIdx < src.size), function copyListRecursiveIfNested, file in_mem_overflow_buffer_utils.cpp, line 31.
[1]    89962 abort      ./kuzu_shell -i db

CSV: https://gist.github.com/rfdavid/ba4d28cbcd2c727794fe59af4adc74ef

@andyfengHKU
Copy link
Contributor

Hi Rui,

We will look into this. Meanwhile I think benchmarking PR #1327 meaning you need a Rel table with a STRING property and test the scan performance of reading that property.

E.g.

MATCH (a:person)-[e:knows]->(b:person) RETURN e.strProp

@acquamarin
Copy link
Collaborator

acquamarin commented Mar 7, 2023

Hi Rui,

I tried to load the csv you provided and query the Preference table. However, i can't reproduce the error you reported. Could you please provide me your building environment so i can better dig into this issue?

Thanks,

Ziyi

@rfdavid
Copy link
Collaborator Author

rfdavid commented Mar 7, 2023

Hi Ziyi,

I built both on debug and release, and basically ran the following

DROP table Preference; 
CREATE NODE TABLE Preference(name STRING, pref STRING[],  PRIMARY KEY (name)) ; 
COPY Preference FROM "pref.csv"; 
match (p:Preference) return p.pref;

In release (both compiling and downloading from the website), the query runs normally and doesn't produce any seg fault. I'm running on Apple Silicon. Is there anything more specific that I can provide?

Rui

@acquamarin
Copy link
Collaborator

Hi Rui,

Thanks for you feedback, I could reproduce the bug under Apple Silicon and DEBUG mode. We will fix this bug as soon as possible.

Ziyi

@acquamarin
Copy link
Collaborator

Hi Rui,

This bug is caused by copying an empty list and i have fixed it in PR #1358. Can you try to load your csv again and confirm whether the bug has been solved.

@rfdavid
Copy link
Collaborator Author

rfdavid commented Mar 8, 2023

I compiled it again and everything is working now 👍

@rfdavid rfdavid closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants