Backports of 81db7e6 and bc7f240 #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In b0d0a68, we incorrectly dropped a check that skips setting the "cdi.kubevirt.io/storage.bind.immediate.requested" annotation when using virt-v2v on el9 - in that case, the conversion pod acts as the first-consumer of the data volume and thus, there is no need in artificial first-consumer pod. Signed-off-by: Arik Hadas <ahadas@redhat.com>
Previously, we assumed all disks of types VirtualDiskFlatVer1BackingInfo, VirtualDiskFlatVer2BackingInfo and VirtualDiskRawDiskMappingVer1BackingInfo are located on a datastore. The only exception was disks of type VirtualDiskRawDiskVer2BackingInfo for which we didn't assume they are located on a datastore but for them RDM is set to true and so we have a critical concern saying VMs which such disks cannot be migrated. However, the 'Datastore' property is optional and according to the vSphere documentation: "If the file is not located on a datastore, then this reference is null.". We noticed that this could actually happen, even though we were not able to reproduce it on our development environments, and once it happens forklift-controller crashes while creating the inventory. Therefore this PR introduces the following changes: 1. Make the code that builds the inventory more robust in terms of handling VMs with disks that are not located on a datastore 2. Add a critical concern for such VMs with disks that are not located on a datastore, saying such VMs cannot be migrated (later on we will anyway fail the validation of a plan due to unmapped storage in this case, even if we don't block migration of VMs with critical concerns) Signed-off-by: Arik Hadas <ahadas@redhat.com>
|
liranr23
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #848 and #859