fix(): Reconciles port numbers in the ovpn client deployment #333
Conversation
kon3m
requested review from
narmidm,
bharath-avesha,
Rahul-D78,
gourishkb and
mridulgain
as code owners
|
one issue I notices the commits are unverified (No user is associated with the committer email). We require every contributor to certify that they are legally permitted to contribute to our project. A contributor expresses this by consciously signing their commits. please follow this link. Let us know if you need any help. |
kon3m
force-pushed
the
fix-ovpn-client-port
branch
3 times, most recently
from
4e8de96
to
8998f6e
Compare
|
@narmidm the commits are verified now. |
|
Thanks for reviewing @Rahul-D78 |
|
@kon3m Please mark the PR as ready for review when you are done. I will review it as soon as possible. |
|
@narmidm i have found an issue with this fix where in some cases distinct ports do not get assigned to the client deployments or to put in another way both the clients are connected to the same nodePort which should not happen. Thats the reason i have converted the PR to draft. Now i have updated the PR adding the fix for that as well, could you please review it? |
|
@kon3m , can you rebase with the latest master. it has some fixes of E2E pipeline. After That I will trigger the E2E again. |
kon3m
force-pushed
the
fix-ovpn-client-port
branch
from
3984ab8
to
ceddb76
Compare
|
@narmidm done, i have just rebased with master and pushed. |
kon3m
force-pushed
the
fix-ovpn-client-port
branch
2 times, most recently
from
237dc66
to
d72db75
Compare
|
Urgent CRD changes are slated for release, and we will wait a couple of days for this PR to merge. @kon3m, you will likely need to sync your branch as well. |
* feat(): api changes for no-net slice Signed-off-by: Mridul Gain <mridulgain@gmail.com> * feat(): block reconcilation of networking part Signed-off-by: Mridul Gain <mridulgain@gmail.com> * cluster reconciler changes for no net Signed-off-by: Mridul Gain <mridulgain@gmail.com> * skip workerslice health for no-net deployment Signed-off-by: Mridul Gain <mridulgain@gmail.com> * update slice reconciler for no-net Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(): update cluster status to show network present or not Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(): ITs & go version update Signed-off-by: Mridul Gain <mridulgain@gmail.com> * fix(): update apis tag Signed-off-by: Mridul Gain <mridulgain@gmail.com> --------- Signed-off-by: Mridul Gain <mridulgain@gmail.com>
Signed-off-by: kon3m <konemshad@gmail.com>
Signed-off-by: kon3m <konemshad@gmail.com>
Signed-off-by: kon3m <konemshad@gmail.com>
Signed-off-by: kon3m <konemshad@gmail.com>
Signed-off-by: kon3m <konemshad@gmail.com>
Signed-off-by: kon3m <konemshad@gmail.com>
kon3m
force-pushed
the
fix-ovpn-client-port
branch
from
3983917
to
5d7a82a
Compare
Signed-off-by: kon3m <konemshad@com.gmail.com>
kon3m
force-pushed
the
fix-ovpn-client-port
branch
from
5d7a82a
to
c613169
Compare
|
@narmidm @Rahul-D78 @bharath-avesha Closing this PR and will open a new/clean one as multiple authors and files got added which are not related to this PR. Will comment the new PR once i open it. This is the newly opened PR : 368 |
|
Opened a new clean PR |
Description
Fixes #309
How Has This Been Tested?
Tested it manually using two single node kind clusters, will write test cases soon using envtest and update the PR
Checklist:
go fmtDoes this PR introduce a breaking change?