Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project logo overlapping with other parts of nav bar #47984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix project logo overlapping with other parts of nav bar #47984

wants to merge 1 commit into from

Conversation

thisisharrsh
Copy link
Contributor

Fixes : #47889

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@thisisharrsh thisisharrsh mentioned this pull request Sep 18, 2024
Open
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e583516
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66eac2d3c8871e0008bd4bc3
😎 Deploy Preview https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisisharrsh
Copy link
Contributor Author

As discussed in the related issue, I have managed the size of the search box. Attached is the screen shot of the deployed navbar. 
Screenshot from 2024-09-18 17-49-00

@thisisharrsh thisisharrsh marked this pull request as ready for review September 18, 2024 12:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@thisisharrsh
Copy link
Contributor Author

Deployment preview: https://deploy-preview-47984--kubernetes-io-main-staging.netlify.app/

@sftim
Copy link
Contributor

sftim commented Sep 18, 2024

/retitle Fix project logo overlapping with other parts of nav bar

@k8s-ci-robot k8s-ci-robot changed the title Logo overlaps with other navbar elements Fix project logo overlapping with other parts of nav bar Sep 18, 2024
sftim
sftim reviewed Sep 18, 2024
View reviewed changes
assets/scss/_custom.scss
padding: 8px;
height: 40px;
font-size: 14px;
transition: width 0.3s ease-in-out;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a transition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a transition?

I have used the transition property to facilitate the smooth transition when the width of the search box changes, and it leads to a better user experience. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@salaxander salaxander Awaiting requested review from salaxander

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logo overlaps with other nav bar elements when search bar is present (on Firefox)
3 participants
@thisisharrsh @k8s-ci-robot @sftim