Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt-br] Update docs/tasks/tools/install-kubectl-linux.md #48000

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[pt-br] Update docs/tasks/tools/install-kubectl-linux.md #48000

wants to merge 5 commits into from

Conversation

moreirayokoyama
Copy link

Description

This PR solves #47748 , updating the pt-br documentation for installing kubectl on Linux.

Updated content/pt-br/docs/tasks/tools/install-kubectl-linux.md to sync it with en docs.

Issue

Closes: #47748

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @moreirayokoyama!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
@moreirayokoyama
Copy link
Author

There are 5 other commits included to this PR that aren't actually mine. Did I do something wrong? I just did the rebase as was suggested by the contributor guide, but maybe I did it wrong. If anyone could help me figure this out, I'll fix it.

@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ab8b1b3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66ecfc6499eeee0008832286
😎 Deploy Preview https://deploy-preview-48000--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stormqueen1990
Copy link
Member

stormqueen1990 commented Sep 19, 2024 via email •
edited
Loading

@k8s-ci-robot k8s-ci-robot removed language/zh Issues or PRs related to Chinese language area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 19, 2024
@moreirayokoyama
Copy link
Author

After reading the Contributor CheatSheet, I figure it's ok to push --force to fix the issue. So, now it seems alright.

@stormqueen1990
Copy link
Member

stormqueen1990 commented Sep 19, 2024 via email

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: limck5856
Once this PR has been reviewed and has the lgtm label, please assign edsoncelio for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stormqueen1990
Copy link
Member

After reading the Contributor CheatSheet, I figure it's ok to push --force to fix the issue. So, now it seems alright.

Hi there, @moreirayokoyama! Yes, squashing, rebasing and force-pushing are OK, though it might be a good idea to use --force-with-lease instead 😄

I'm gonna take a look at your PR soon. Are you OK with comments in Portuguese?

@stormqueen1990
Copy link
Member

/remove-cc @jimangel

@stormqueen1990
Copy link
Member

/uncc jimangel

@k8s-ci-robot k8s-ci-robot removed the request for review from jimangel September 19, 2024 14:51
@moreirayokoyama
Copy link
Author

Are you OK with comments in Portuguese?

Yes, I am. Thanks.

stormqueen1990
stormqueen1990 reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olá @moreirayokoyama, muito obrigada pela tua contribuição! 😄

Encontrei alguns pontos que precisam ser ajustados. Caso tenhas dúvidas ou discorde de quaisquer dos pontos, podemos discutir no canal #kubernetes-docs-pt do Slack do Kubernetes.

Depois que tu fizeres os ajustes, podes me solicitar uma nova revisão usando /cc stormqueen1990.

content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
content/pt-br/docs/tasks/tools/install-kubectl-linux.md Outdated Show resolved Hide resolved
@stormqueen1990
Copy link
Member

/retitle [pt-br] Update docs/tasks/tools/install-kubectl-linux.md

@k8s-ci-robot k8s-ci-robot changed the title [pt-br] Updating documentation to Install Kubectl on Linux [pt-br] Update docs/tasks/tools/install-kubectl-linux.md Sep 19, 2024
@moreirayokoyama @stormqueen1990
Replacing falso for simbólico as a more adequate translation for …
05b39f9 
…`dummy`

Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 19, 2024
moreirayokoyama and others added 3 commits September 20, 2024 01:33
@moreirayokoyama @stormqueen1990
Apply suggestions from code review (Typos and small adjustments)
d96df2c 
Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
@moreirayokoyama
Fixing command for downloading public signing key for Kubernetes apt …
bb33b73 
…repository
@moreirayokoyama @stormqueen1990
Apply suggestions from code review (fixing indentation for better ren…
ab8b1b3 
…dering)

Co-authored-by: Mauren <698465+stormqueen1990@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 20, 2024
@stormqueen1990
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 20, 2024
stormqueen1990
stormqueen1990 reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigada pela contribuição! 🎉

/lgtm
/assign @edsoncelio
para segunda revisão

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 579cf96040261af21a6169f3632b54dba0422c92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

@limck5856 limck5856 limck5856 approved these changes

@devlware devlware Awaiting requested review from devlware

@MrErlison MrErlison Awaiting requested review from MrErlison

Assignees

@stormqueen1990 stormqueen1990

@edsoncelio edsoncelio

Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pt-br] Install kubectl on Linux page is outdated
5 participants
@moreirayokoyama @k8s-ci-robot @stormqueen1990 @limck5856 @edsoncelio