Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Removing old CSS includes from K8s basics tutorials #45327

Closed
seifrajhi opened this issue Feb 25, 2024 · 1 comment · Fixed by #45328
Closed

[fr] Removing old CSS includes from K8s basics tutorials #45327

seifrajhi opened this issue Feb 25, 2024 · 1 comment · Fixed by #45328
Labels
area/localization General issues or PRs related to localization kind/bug Categorizes issue or PR as related to a bug. language/fr Issues or PRs related to French language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@seifrajhi
Copy link
Member

seifrajhi commented Feb 25, 2024

French tutorials still include old CSS files. However, if you visit these pages, the browser will try to access them and return 404 (e.g.).

They were removed from the English tutorials in #34188. This PR removes them from the French localisation.

PS: Not directly related to this PR, even though https://katacoda.com/embed.js was included on those pages next to the CSS files I did not remove them.

I also wanted to let you know that all Katacoda-related pieces should be removed from the localisation since these interactive tutorials are not supported anymore and need replacing. Here is an umbrella issue for this task #41496

To get rid of Katacoda, many texts need corrections, which I can't do without French team knowledge.

/sig docs
/language fr
/area localization

@seifrajhi seifrajhi added the kind/bug Categorizes issue or PR as related to a bug. label Feb 25, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/fr Issues or PRs related to French language area/localization General issues or PRs related to localization labels Feb 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization kind/bug Categorizes issue or PR as related to a bug. language/fr Issues or PRs related to French language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants