-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go-runner: switch to debian bookworm #3233
go-runner: switch to debian bookworm #3233
Conversation
go1.21-bullseye: | ||
CONFIG: 'go1.21-bullseye' | ||
IMAGE_VERSION: 'v2.3.1-go1.21.0-bullseye.0' | ||
go1.21-bookworm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep both for now or that is not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say we switch completely to bookworm with golang 1.21. Would that work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, thanks
/lgtm
/approve
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
cbd6a10
to
b587261
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use debian 12 for go runner image.
Which issue(s) this PR fixes:
Refers to #3128
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?