Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update debian-iptables and distroless-iptables to use go 1.20.5 #3107

Merged
merged 2 commits into from
Jun 7, 2023
Merged

update debian-iptables and distroless-iptables to use go 1.20.5 #3107

merged 2 commits into from
Jun 7, 2023

Conversation

jeremyrickard
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • update debian-iptables and distroless-iptables to utilize Go 1.20.5

Which issue(s) this PR fixes:

ref: #3099

Special notes for your reviewer:

Images expected 06 June 2023

Does this PR introduce a user-facing change?

debian-iptables and distroless-iptables are now built with Go 1.20.5

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 6, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and jrsapi June 6, 2023 13:53
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2023
@jeremyrickard
Copy link
Contributor Author

/assign @Verolop @xmudrii @cpanato @saschagrunert @puerco
cc: @kubernetes/release-engineering

@jeremyrickard
Copy link
Contributor Author

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 6, 2023
@jeremyrickard jeremyrickard mentioned this pull request Jun 6, 2023
Closed
32 tasks
cpanato
cpanato approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, jeremyrickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,jeremyrickard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wespanther
Copy link
Contributor

Can we get this one merged first?

Otherwise I think we'll still see some libssl CVEs in the new image.

@cpanato
Copy link
Member

cpanato commented Jun 7, 2023

/test all

@jeremyrickard jeremyrickard marked this pull request as ready for review June 7, 2023 15:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@jeremyrickard
update debian-iptables and distroless-iptables to use go 1.20.5
9a6bbea 
Signed-off-by: Jeremy Rickard <jeremyrrickard@gmail.com>
@jeremyrickard
Bump missing versions in dependencies
fd25e8c 
Signed-off-by: Jeremy Rickard <jeremyrrickard@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@jeremyrickard
Copy link
Contributor Author

/retest

@cpanato
Copy link
Member

cpanato commented Jun 7, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@jeremyrickard
Copy link
Contributor Author

/test pull-release-image-distroless-iptables

@k8s-ci-robot k8s-ci-robot merged commit e998b48 into kubernetes:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@aojea aojea Awaiting requested review from aojea

@jrsapi jrsapi Awaiting requested review from jrsapi

@robscott robscott Awaiting requested review from robscott

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@puerco puerco

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
8 participants
@jeremyrickard @k8s-ci-robot @wespanther @cpanato @saschagrunert @Verolop @puerco @xmudrii