-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s dependecies to v1.25 #761
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a7250b4
Upgrade to v1.21
yaron-idan e5531f7
update ssh module
yaron-idan d52ac45
fix CVE-2020-8558
yaron-idan f95dd7c
add missing files
yaron-idan c03202f
Merge remote-tracking branch 'upstream/master' into CVE-2020-8558
yaron-idan f074a82
remove .idea
yaron-idan 184f371
check if meminfo pointer is not nil
yaron-idan 48518d0
check pointer items are not nil
yaron-idan 75dd516
add nil pointer conditions
yaron-idan f6c428f
fix condition
yaron-idan e31f5a3
add context
yaron-idan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| #!/bin/bash | ||
|
|
||
| VERSION=${1#"v"} | ||
| if [ -z "$VERSION" ]; then | ||
| echo "Please specify the Kubernetes version: e.g." | ||
| echo "./download-deps.sh v1.21.0" | ||
| exit 1 | ||
| fi | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| # Find out all the replaced imports, make a list of them. | ||
| MODS=($( | ||
| curl -sS "https://github.com/raw/kubernetes/kubernetes/v${VERSION}/go.mod" | | ||
| sed -n 's|.*k8s.io/\(.*\) => ./staging/src/k8s.io/.*|k8s.io/\1|p' | ||
| )) | ||
|
|
||
| # Now add those similar replace statements in the local go.mod file, but first find the version that | ||
| # the Kubernetes is using for them. | ||
| for MOD in "${MODS[@]}"; do | ||
| V=$( | ||
| go mod download -json "${MOD}@kubernetes-${VERSION}" | | ||
| sed -n 's|.*"Version": "\(.*\)".*|\1|p' | ||
| ) | ||
|
|
||
| go mod edit "-replace=${MOD}=${MOD}@${V}" | ||
| done | ||
|
|
||
| go get "k8s.io/kubernetes@v${VERSION}" | ||
| go mod download |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the status of go mod graph. Although k8s.io related dependencies are set to 1.25.10 in replace rules, the actual required version is 1.27. we need to find the library which requires k8s.io 1.27 and downgrade them if any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any mention of v1.27 when running
go mod graph, are you sure it's been required somewhere in the project?