Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NPD metrics mode #284

Closed
7 tasks done
xueweiz opened this issue Jun 3, 2019 · 6 comments
Closed
7 tasks done

Implement NPD metrics mode #284

xueweiz opened this issue Jun 3, 2019 · 6 comments
Assignees

Comments

@xueweiz
Copy link
Contributor

xueweiz commented Jun 3, 2019

Here is the proposal.

This issue tracks the implementation of the proposal:

@wangzhen127
Copy link
Member

/cc @wangzhen127

@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 3, 2019

/cc @Random-Liu @jiayingz @dchen1107

@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 4, 2019

/assign @xueweiz

@andyxning
Copy link
Member

/cc @andyxning

@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 22, 2019

/cc @kewu1992

@xueweiz
Copy link
Contributor Author

xueweiz commented Jul 25, 2019

Now that #315 is merged, this issue is finally complete! It will be release in NPD v0.7.0

Huge thanks to Zhen, Lantao and Andy for the reviews and feedback!

There are a few follow up improvements, most importantly, e2e tests for NPD (#296). I really want e2e test to happen, so that we can have more confidence when changing NPD code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants