docker-env script for tcsh is not correct

[ColleIsarco]

Steps to reproduce the issue:

1. Login with default shell set to tcsh
2. start minikube on docker: minikube start --driver=docker
3. execute command to print out environment: minikube docker-env
4. or name shell explicity: minikube docker-env --shell=tcsh

Full output of minikube logs command:
Not needed here...

Full output of failed command:

export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.99.100:32771"
export DOCKER_CERT_PATH="/home/andi/.minikube/certs"
export MINIKUBE_ACTIVE_DOCKERD="minikube"

# To point your shell to minikube's docker-daemon, run:
# eval $(minikube -p minikube docker-env)

But the expected output should look like this:

setenv DOCKER_TLS_VERIFY "1"
setenv DOCKER_HOST "tcp://192.168.99.100:32771"
setenv DOCKER_CERT_PATH "/home/andi/.minikube/certs"
setenv MINIKUBE_ACTIVE_DOCKERD "minikube"

# To point your shell to minikube's docker-daemon, run:
# eval `minikube -p minikube docker-env`

In no Go-expert, but it seems that the source-codefor handling a (t)csh-shell differently than bash or similar shells is missing. The docker here is running on a vm, but at least by explicitly naming the shell I expect the correct script.

[afbjorklund]

I think support for csh was missed, when the command and shell was forked out from docker-machine.

c847979

So docker-machine env --shell=tcsh works, but minikube docker-env --shell=tcsh does not

Guess nobody uses csh...

[afbjorklund]

$ docker-machine env --shell=bash
export DOCKER_TLS_VERIFY="1"
export DOCKER_HOST="tcp://192.168.99.254:2376"
export DOCKER_CERT_PATH="/home/anders/.docker/machine/machines/default"
export DOCKER_MACHINE_NAME="default"
# Run this command to configure your shell: 
# eval $(docker-machine env --shell=bash)
$ docker-machine env --shell=tcsh
setenv DOCKER_TLS_VERIFY "1";
setenv DOCKER_HOST "tcp://192.168.99.254:2376";
setenv DOCKER_CERT_PATH "/home/anders/.docker/machine/machines/default";
setenv DOCKER_MACHINE_NAME "default";
: Run this command to configure your shell: 
: eval `docker-machine env --shell=tcsh`

Needs porting over to pkg/minikube/shell

[sharifelgamal]

yeah, this is just missing functionality in minikube, should be a pretty simple fix.

[sharifelgamal]

should be as simple as adding an entry for tsch in the map at https://github.com/kubernetes/minikube/blob/master/pkg/minikube/shell/shell.go#L60

[ColleIsarco]

Thank you for fixing this issue so fast