Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: add CRI timeout(s) #3098

Closed
saschagrunert opened this issue Aug 15, 2024 · 4 comments
Closed

kubeadm: add CRI timeout(s) #3098

saschagrunert opened this issue Aug 15, 2024 · 4 comments
Assignees
Labels
area/cri kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@saschagrunert
Copy link
Member

Right now the timeout is hardcoded and inherited from previous critcl times:

https://github.com/kubernetes/kubernetes/blob/026c55e40de835464e769bad65c8a19940b61459/cmd/kubeadm/app/util/runtime/runtime.go#L63-L64

The pull timeout is set to unlimited, which is also the default for critcl:

https://github.com/kubernetes/kubernetes/blob/026c55e40de835464e769bad65c8a19940b61459/cmd/kubeadm/app/util/runtime/runtime.go#L174

Would it make sense to add a generic and pull timeout option to the kubeadm configuration without having a need for a KEP, @kubernetes/kubeadm-maintainers?

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert saschagrunert added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. area/kubeadm labels Aug 15, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 15, 2024
@saschagrunert saschagrunert self-assigned this Aug 15, 2024
@neolit123
Copy link
Member

/transfer kubeadm

@k8s-ci-robot k8s-ci-robot transferred this issue from kubernetes/kubernetes Aug 15, 2024
@neolit123
Copy link
Member

neolit123 commented Aug 15, 2024

the v1beta4 config is locked and we don't have an ETA for vNext.
we don't do like k8s APIs and add fields to released APIs, i.e. ours are set in stone.

such a change missed the timing of v1beta4 which was released with 1.31, next to your addition of using the CRI lib.

best we can do as a quick fix is change the hardcoded timeout.

@neolit123 neolit123 added kind/feature Categorizes issue or PR as related to a new feature. area/cri and removed sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/kubeadm labels Aug 15, 2024
@neolit123 neolit123 added this to the v1.32 milestone Aug 15, 2024
@neolit123 neolit123 added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Aug 15, 2024
@saschagrunert
Copy link
Member Author

@neolit123 then let's close this issue, I think having the crictl timeouts inherited is fine (expected behavior).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cri kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants