Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error checking for pod name & NS #966

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Fix error checking for pod name & NS #966

merged 1 commit into from
Jul 14, 2017

Conversation

claytono
Copy link
Contributor

Previously it would just check if POD_NAME or POD_NAMESPACE was set, which
could lead to very bizarre failure modes.

Previously it would just check if POD_NAME *or* POD_NAMESPACE was set, which
could lead to very bizarre failure modes.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.342% when pulling ad583c3 on claytononeill:fix-env-var-error-checks into d416d02 on kubernetes:master.

@aledbf aledbf self-assigned this Jul 14, 2017
@aledbf
Copy link
Member

aledbf commented Jul 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2017
@aledbf
Copy link
Member

aledbf commented Jul 14, 2017

@ClaytonONeill thanks!

@aledbf aledbf merged commit 8076dea into kubernetes:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants