-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit test cases for core/pkg/ingress/controller/backend_ssl #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chentao1596
commented
Apr 1, 2017
•
edited
Loading
edited
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Apr 1, 2017
chentao1596
changed the title
add unit test cases for core/pkg/ingress/controller/backend_ssl
WIP: add unit test cases for core/pkg/ingress/controller/backend_ssl
Apr 5, 2017
@chentao1596 ping. Can you check the error in the tests? |
@aledbf ok, i will do it as soon as possible, thank you! |
chentao1596
force-pushed
the
back_ssl_test
branch
from
April 11, 2017 03:10
083ca3e
to
ec15291
Compare
chentao1596
force-pushed
the
back_ssl_test
branch
4 times, most recently
from
April 11, 2017 03:30
0a93677
to
2ec3bb8
Compare
chentao1596
force-pushed
the
back_ssl_test
branch
from
April 11, 2017 07:09
a1cffe0
to
c92f491
Compare
Coverage increased (+1.08%) to 45.509% when pulling c92f491eceec4760350ca6816d6ab5a1f082866a on chentao1596:back_ssl_test into 6ed6475 on kubernetes:master. |
chentao1596
force-pushed
the
back_ssl_test
branch
from
April 11, 2017 07:45
c92f491
to
f5baeb2
Compare
chentao1596
changed the title
WIP: add unit test cases for core/pkg/ingress/controller/backend_ssl
add unit test cases for core/pkg/ingress/controller/backend_ssl
Apr 11, 2017
@aledbf hi, i'm sorry for this delay, errors has been resolved, PTAL, thank you! |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Apr 11, 2017
@chentao1596 thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.