Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper enqueue a secret on the secret queue #498

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Proper enqueue a secret on the secret queue #498

merged 1 commit into from
Mar 26, 2017

Conversation

jcmoraisjr
Copy link
Contributor

FIxes #497

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.796% when pulling f945624 on jcmoraisjr:jm-fix-enqueue-secret into e8b61b4 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

@jcmoraisjr thanks!

@aledbf aledbf merged commit b7367a9 into kubernetes:master Mar 26, 2017
@jcmoraisjr jcmoraisjr deleted the jm-fix-enqueue-secret branch March 26, 2017 11:58
@pieterlange
Copy link
Contributor

@gianrubio you were probably hitting this last friday

Thanks @jcmoraisjr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcmoraisjr @k8s-reviewable @coveralls @aledbf @pieterlange @k8s-ci-robot