Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference constant #437

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Reference constant #437

merged 1 commit into from
Mar 14, 2017

Conversation

caiyixiang
Copy link
Contributor

reference to constant is better

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Mar 14, 2017
@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2017
@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

merging. coveral 504 error

@aledbf
Copy link
Member

aledbf commented Mar 14, 2017

@caiyixiang thanks!

@aledbf aledbf merged commit c67e106 into kubernetes:master Mar 14, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 43.082% when pulling 3b152e6 on caiyixiang:Reference_constant into 041f269 on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caiyixiang @k8s-reviewable @aledbf @coveralls @k8s-ci-robot