Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review prometheus docs #1465

Merged
merged 1 commit into from
Oct 3, 2017
Merged

review prometheus docs #1465

merged 1 commit into from
Oct 3, 2017

Conversation

gianrubio
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2017
@aledbf
Copy link
Member

aledbf commented Oct 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@aledbf
Copy link
Member

aledbf commented Oct 3, 2017

@gianrubio thanks!

@aledbf aledbf merged commit 180d0df into kubernetes:master Oct 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.578% when pulling 0813704 on gianrubio:prometheus-docs into 88e6af5 on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gianrubio @k8s-reviewable @aledbf @coveralls @k8s-ci-robot