Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tls ports to rbac nginx ingress controller and service #1403

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Added tls ports to rbac nginx ingress controller and service #1403

merged 1 commit into from
Sep 24, 2017

Conversation

wombat
Copy link
Contributor

@wombat wombat commented Sep 21, 2017

The rbac nginx ingress controller and service were missing tls/https
ports and nodePorts

The rbac nginx ingress controller and service were missing tls/https
ports and nodePorts
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.714% when pulling 4ae356d on w0mbat:master into 37bd14d on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Sep 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2017
@aledbf
Copy link
Member

aledbf commented Sep 24, 2017

@wombat thanks!

@aledbf aledbf merged commit 27d4e8b into kubernetes:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants