Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix README of nginx-ingress-controller #1295

Merged
merged 1 commit into from
Sep 4, 2017
Merged

fix README of nginx-ingress-controller #1295

merged 1 commit into from
Sep 4, 2017

Conversation

dunjut
Copy link

@dunjut dunjut commented Sep 4, 2017

I see examples/default-backend.yaml contains both a Deployment and a Service, then the next line

kubectl expose rc ...

seems to be needless. So fix it smoothly.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 4, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 43.459% when pulling 710eaff on dunjut:master into 1bcfb15 on kubernetes:master.

@aledbf aledbf self-assigned this Sep 4, 2017
@aledbf
Copy link
Member

aledbf commented Sep 4, 2017

/lgtm

@aledbf aledbf closed this Sep 4, 2017
@aledbf aledbf reopened this Sep 4, 2017
@aledbf
Copy link
Member

aledbf commented Sep 4, 2017

@dunjut thanks!

@aledbf aledbf merged commit 85e1a65 into kubernetes:master Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dunjut @k8s-reviewable @coveralls @aledbf @k8s-ci-robot