Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete useless statement #1272

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Delete useless statement #1272

merged 1 commit into from
Aug 30, 2017

Conversation

danielqsj
Copy link
Contributor

!strings.HasSuffix(path, slash) is sufficient here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 30, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 30, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.613% when pulling 493aede on danielqsj:delete-useless-statement into 2d6f811 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 30, 2017
@aledbf
Copy link
Member

aledbf commented Aug 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2017
@aledbf
Copy link
Member

aledbf commented Aug 30, 2017

@danielqsj thanks!

@aledbf aledbf merged commit 58c94d4 into kubernetes:master Aug 30, 2017
@danielqsj danielqsj mentioned this pull request Nov 16, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danielqsj @k8s-reviewable @coveralls @aledbf @k8s-ci-robot