Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for strings.StringInSlice #101

Merged
merged 1 commit into from
Jan 2, 2017
Merged

Add unit test for strings.StringInSlice #101

merged 1 commit into from
Jan 2, 2017

Conversation

chentao1596
Copy link

Add unit test, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 1, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 39.916% when pulling 1bd97e8 on chentao1596:add-unit-test-for-strings into 756b41b on kubernetes:master.

@aledbf aledbf self-assigned this Jan 2, 2017
@aledbf
Copy link
Member

aledbf commented Jan 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2017
@aledbf
Copy link
Member

aledbf commented Jan 2, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit b43ab74 into kubernetes:master Jan 2, 2017
@chentao1596 chentao1596 deleted the add-unit-test-for-strings branch January 3, 2017 00:35
haoqing0110 pushed a commit to stolostron/management-ingress that referenced this pull request Mar 5, 2021
fix rhel build issue (kubernetes#101)
2c7315e
@jurrehart jurrehart mentioned this pull request Feb 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @k8s-ci-robot @chentao11596