Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx vts as prometheus metrics #72

Closed
gianrubio opened this issue Dec 21, 2016 · 8 comments · Fixed by #423
Closed

Nginx vts as prometheus metrics #72

gianrubio opened this issue Dec 21, 2016 · 8 comments · Fixed by #423

Comments

@gianrubio
Copy link
Contributor

Currently the nginx endpoint for metrics only support vts metric, that provide html and json metrics.
I figured out a project that export vts metrics to prometheus, now I have all metrics, simply using a sidecar container pointing to vts. Here's my awesome metrics.

screen shot 2016-12-21 at 15 21 42

I'm interested in porting this for the nginx ingress, but first I'm here to ask if this is in the roadmap or if anyone is already working on this.

@aledbf
Copy link
Member

aledbf commented Dec 21, 2016

@gianrubio prometheus metrics are already present in master (only for standard nginx, not vts). Please check #36
Maybe you can open a PR to extract the metrics from the vts module?

@gianrubio
Copy link
Contributor Author

@aledbf you are wright, there's an endpoint for global nginx metrics.
I can do this PR, what dou you think is the better way to do this?

1 - Create another endpoint for metrics
2 - Merge this vts metrics with global
3 - Run a sidecar container extracting vts metrics?

@aledbf
Copy link
Member

aledbf commented Dec 21, 2016

2 - Merge this vts metrics with global

@cmluciano
Copy link
Contributor

@gianrubio Are you still interested in working on this?

@gianrubio
Copy link
Contributor Author

yes @cmluciano, I'm working on this, 70% is done. Give me more 2 days and I'll submit this PR

@hartmut-pq
Copy link

Hi, been reading cross many issues, PRs, .. unsure if I should open a separate issue or not..

Are there any plans to add metrics from https://github.com/hnlq715/nginx-vts-exporter ?

mostly interested in

{NAMESPACE}_server_requests | code [2xx, 3xx, 4xx, 5xx, total], host (or domain name)

@gianrubio
Copy link
Contributor Author

@harmut-pq take a look on this config https://github.com/kubernetes/ingress/blob/master/examples/customization/custom-vts-metrics/nginx/nginx-vts-metrics-conf.yaml
If this didn't help you, please open a new issue and relate to me

@hartmut-pq
Copy link

Hi @gianrubio, thanks for the hint!
This configuration enabled some more vts metrics - can't find any response codes though. Is this supported in any way?

haoqing0110 referenced this issue in stolostron/management-ingress Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants