This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Avoid replacing nginx.conf file with invalid content #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
cncf-cla: yes
aledbf
force-pushed
the
check-new-error
branch
from
93eafd4
to
edea5ad
Compare
bprashanth
reviewed
Sep 29, 2016
| @@ -91,7 +91,9 @@ func (t *Template) Close() { | |||
|
|
|||
| // Write populates a buffer using a template with NGINX configuration | |||
| // and the servers and upstreams created by Ingress rules | |||
| func (t *Template) Write(cfg config.Configuration, ingressCfg ingress.Configuration) ([]byte, error) { | |||
| func (t *Template) Write(cfg config.Configuration, | |||
There was a problem hiding this comment.
nit: please move cfg onto a line on its own
|
lgtm just the nit |
aledbf
force-pushed
the
check-new-error
branch
from
edea5ad
to
fd6b4dd
Compare
|
Automatic merge from submit-queue |
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
Automatic merge from submit-queue [nginx-ingress-controller] Avoid replacing nginx.conf file with invalid content
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is