This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Readiness probe that works behind a CP lb #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bprashanth
reviewed
Sep 16, 2016
| @@ -265,6 +265,12 @@ http { | |||
| {{ end }} | |||
|
|
|||
| {{ if eq $server.Name "_" }} | |||
| # health checks in cloud providers require the use of port 80 | |||
| location /ingress-controller-healthz { | |||
There was a problem hiding this comment.
can you make this the default, and allow people to config it through yaml?
There was a problem hiding this comment.
Using a flag with /ingress-controller-healthz as default is ok?
There was a problem hiding this comment.
any reason it shouldn't be a flag? if i have an ingress controller behind an ingress controller how would i modify it :)
aledbf
force-pushed
the
cloud-health-check
branch
from
048251c
to
9cbcf36
Compare
|
Thanks LGTM, modifying title to note have wip |
bprashanth
changed the title
bprashanth
added
lgtm
|
oh please add a todo to scrub incoming ingresses for the url passed through the arg (can come laters, or just file a bug so we can track it) |
done #1754 |
|
recomputing cla status... |
k8s-github-robot
added
the
cncf-cla: yes
|
Automatic merge from submit-queue |
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
…heck Automatic merge from submit-queue [nginx-ingress-controller] Readiness probe that works behind a CP lb fixes kubernetes-retired#1507
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1507
This change is