This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller]: Use ClientConfig to configure connection #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
changed the title
|
@bprashanth this makes sense to simplify the connection from outside the cluster? |
|
In the outside cluster case, does it actually write out nginx.conf as new ingresses are created in the cluster? Does it work with hack/local-up-cluster.sh (no service account)? I don't remember when/if we started teaching ClientConfig to do the right thing from within a pod in the cluster, test it, if it works now then great. |
Yes, it works without issues. |
|
@bprashanth ping |
|
LGTM |
|
Automatic merge from submit-queue |
aledbf
pushed a commit
to aledbf/contrib
that referenced
this pull request
Nov 10, 2016
Automatic merge from submit-queue [nginx-ingress-controller]: Use ClientConfig to configure connection fixes kubernetes-retired#1459 Running with `docker run`: ``` core@localhost ~ $ docker run -it aledbf/nginx-third-party:0.31 bash root@f6a96f46eab0:/# export KUBERNETES_MASTER=http://172.17.4.99:8080 root@f6a96f46eab0:/# /nginx-ingress-controller --default-backend-service=default/nginx-errors I0802 14:44:58.604384 7 main.go:94] Using build: https://github.com/aledbf/contrib - git-5b9146a W0802 14:44:58.605282 7 main.go:118] unexpected error getting runtime information: unable to get POD information (missing POD_NAME or POD_NAMESPACE environment variable) I0802 14:44:58.607270 7 main.go:123] Validated default/nginx-errors as the default backend W0802 14:44:58.611322 7 ssl.go:132] no file dhparam.pem found in secrets I0802 14:44:58.615637 7 controller.go:1128] starting NGINX loadbalancer controller I0802 14:44:58.615902 7 command.go:35] Starting NGINX process... ``` Running inside in a cluster: ``` I0802 14:47:50.254736 1 main.go:94] Using build: https://github.com/aledbf/contrib - git-5b9146a I0802 14:47:50.254920 1 merged_client_builder.go:103] No kubeconfig could be created, falling back to service account. I0802 14:47:50.343440 1 main.go:123] Validated default/nginx-errors as the default backend W0802 14:47:50.343677 1 ssl.go:132] no file dhparam.pem found in secrets I0802 14:47:50.347322 1 controller.go:1128] starting NGINX loadbalancer controller I0802 14:47:50.347870 1 command.go:35] Starting NGINX process... ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/contrib/1467) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1459
Running with
docker run:Running inside in a cluster:
This change is