This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[nginx-ingress-controller] Allow custom health checks in upstreams #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledbf
force-pushed
the
nginx-check-upstreams
branch
2 times, most recently
from
8412c12
to
7db9b60
Compare
aledbf
force-pushed
the
nginx-check-upstreams
branch
from
7db9b60
to
a95cbe4
Compare
|
still wip? |
aledbf
changed the title
|
Sorry. title updated |
aledbf
force-pushed
the
nginx-check-upstreams
branch
from
a95cbe4
to
8b3a3c8
Compare
aledbf
force-pushed
the
nginx-check-upstreams
branch
from
8b3a3c8
to
97914b4
Compare
| @@ -196,6 +196,23 @@ Use the [custom-template](examples/custom-template/README.md) example as a guide | |||
| **Please note the template is tied to the go code. Be sure to no change names in the variable `$cfg`** | |||
|
|
|||
|
|
|||
| ### Custom NGINX upstream checks | |||
|
|
|||
| NGINX exposes some flags in the [upstream configuration](http://nginx.org/en/docs/http/ngx_http_upstream_module.html#upstream) that enabled configuration of each server in the upstream. The ingress controller allows custom `max_fails` and `fail_timeout` parameters in a global context using `upstream-max-fails` or `upstream-fail-timeout` in the NGINX Configmap or in a particular Ingress rule. By default this values are 0. This means NGINX will respect the `livenessProbe`, if is defined. If there is no probe, NGINX will not mark a server inside an upstream down. | |||
There was a problem hiding this comment.
s/liveness/readiness
Also this language makes me think nginx scrapes the pods for their readiness probes but that's not the case. Please clarify with something like: nginx will not health check your backends, and whenever the endpoints controller notices a readiness probe failure that pod's ip will be removed from the list of endpoints, causing nginx to also remove it from the upstreams.
|
LGTM but for the one comment, you can fix that in a follow up |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #818