Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible wrong file reference on Ansible Installation steps #9803

Closed
yiskaneto opened this issue Feb 18, 2023 · 3 comments · Fixed by #9842
Closed

Possible wrong file reference on Ansible Installation steps #9803

yiskaneto opened this issue Feb 18, 2023 · 3 comments · Fixed by #9842
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@yiskaneto
Copy link

I'm following the instructions to install ansible https://github.com/kubernetes-sigs/kubespray/blob/v2.21.0/docs/ansible.md#installing-ansible and noticed that after running pip install -U -r requirements-$ANSIBLE_VERSION.txt (which works) the following commands (test and ansible-galaxy) are run against the files requirements-$ANSIBLE_VERSION.yml which don't exist, am I missing something?

@yiskaneto yiskaneto added the kind/bug Categorizes issue or PR as related to a bug. label Feb 18, 2023
@JaneLiuL
Copy link
Member

have you declare the variable as below? this is mention here: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/ansible.md

VENVDIR=kubespray-venv
KUBESPRAYDIR=kubespray
ANSIBLE_VERSION=2.12
virtualenv  --python=$(which python3) $VENVDIR

@yiskaneto
Copy link
Author

yiskaneto commented Feb 20, 2023

have you declare the variable as below? this is mention here: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/ansible.md

VENVDIR=kubespray-venv
KUBESPRAYDIR=kubespray
ANSIBLE_VERSION=2.12
virtualenv  --python=$(which python3) $VENVDIR

That's correct, installing the requirements with Python is not an issue, my point here is that there is possible doc bug cause the requirements-$ANSIBLE_VERSION.yml(noticed the yml extension of the requirements file) doesn't exist, the files that exist are requierements-2.11.txt and requirements-2.12.txt, consequently the commands (From Installing-ansible) below won't work

test -f requirements-$ANSIBLE_VERSION.yml && \
  ansible-galaxy role install -r requirements-$ANSIBLE_VERSION.yml && \
  ansible-galaxy collection -r requirements-$ANSIBLE_VERSION.yml

@oomichi
Copy link
Contributor

oomichi commented Mar 1, 2023

have you declare the variable as below? this is mention here: https://github.com/kubernetes-sigs/kubespray/blob/master/docs/ansible.md

VENVDIR=kubespray-venv
KUBESPRAYDIR=kubespray
ANSIBLE_VERSION=2.12
virtualenv  --python=$(which python3) $VENVDIR

That's correct, installing the requirements with Python is not an issue, my point here is that there is possible doc bug cause the requirements-$ANSIBLE_VERSION.yml(noticed the yml extension of the requirements file) doesn't exist, the files that exist are requierements-2.11.txt and requirements-2.12.txt, consequently the commands (From Installing-ansible) below won't work

test -f requirements-$ANSIBLE_VERSION.yml && \
  ansible-galaxy role install -r requirements-$ANSIBLE_VERSION.yml && \
  ansible-galaxy collection -r requirements-$ANSIBLE_VERSION.yml

Thanks for your explanation, that makes sense for me.
Let me try to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants