Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linode): don't try to create existing records #3903

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

wbh1
Copy link
Contributor

@wbh1 wbh1 commented Sep 1, 2023

Description

A bug in the Linode provider can result in an unbounded explosion of TXT records being created. For example, if external-dns attempts to create a CNAME in a zone that has a conflicting A record, it will fail but will still create 2 new TXT records every single time.

Instead, we can just skip creating records that already exist since they should only ever be in the list of updates.

Fixes #3045

Checklist

  • Unit tests updated
  • End user documentation updated

A bug in the Linode provider can result in an unbounded explosion of TXT records being created.
For example, if external-dns attempts to create a CNAME in a zone that has a conflicting A record,
it will fail but will still create 2 new TXT records every single time.

Instead, we can just skip creating records that already exist since they should
only ever be in the list of updates.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @wbh1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 1, 2023
@mloiseleur
Copy link
Contributor

Hello @wbh1,

This PR also needs a test, in order to ensure it won't happen again.

Records should not be created if they already exist. We skip them.
If records already exist, they should be in the list of updates.
@wbh1
Copy link
Contributor Author

wbh1 commented Sep 6, 2023

Thanks, @mloiseleur. Test updated 😄

@mloiseleur
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@Raffo
Copy link
Contributor

Raffo commented Sep 10, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 627f46b into kubernetes-sigs:master Sep 10, 2023
10 checks passed
@boskiv boskiv mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linode example not updating A record, but creating hundreds of TXT records
4 participants