-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional fields to GCPManagedMachinePool #944
Add additional fields to GCPManagedMachinePool #944
Conversation
|
Welcome @akshay196-rafay! |
Hi @akshay196-rafay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
9228eed
to
acef7b1
Compare
@richardcase This PR is now ready for review. |
@akshay196-rafay - i think we should perhaps re-think the approach going forward. So that we split the aditions up into smaller PRs where each contains:
I appreciate this is following the original approach for the GKE implementation but i think it may be better for to do this incrementally. wdyt? |
I understand where you're coming from. Since GCPManagedMachinePool's new fields are comparatively less I can continue working on this same PR to add reconciliation changes, validation webhooks and e2e of GCPManagedMachinePool. For the GCPManagedControlPlane PR raised by @aniruddha2000 we can take the incremental approach something like this - Steps 1 Steps 2 |
@akshay196-rafay - sounds good to me 👍 Ping me when the reconciliation for the new fields has been added. Thank you for taking this work on. |
acef7b1
to
11b6d09
Compare
11b6d09
to
cd97dfa
Compare
cd97dfa
to
b92aa31
Compare
ff9b4f3
to
d3425ba
Compare
@richardcase @gzcharleszhang Addressed your review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit comment otherwise LGTM. I'll wait for @richardcase and @cpanato to take a look/approve.
err = s.updateNodePoolVersionOrImage(ctx, nodePoolUpdateVersionOrImage) | ||
needUpdateNodePool, nodePoolUpdateNodePool := s.checkDiffAndPrepareUpdateNodePool(nodePool) | ||
if needUpdateNodePool { | ||
log.Info("Node pool version/labels/taints/locations/image type/network tags update required") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can just be something like Node pool config update required
, we may update other fields here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
d3425ba
to
86f466b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akshay196-rafay , this looks good to me. Just one small nit.
@@ -354,6 +354,27 @@ func (s *Service) checkDiffAndPrepareUpdateVersionOrImage(existingNodePool *cont | |||
Taints: desiredKubernetesTaints, | |||
} | |||
} | |||
// Locations | |||
desiredLocations := s.scope.GCPManagedMachinePool.Spec.NodeLocations | |||
if !reflect.DeepEqual(desiredLocations, existingNodePool.Locations) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to use cmp.Equals?
(and also the other instances below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Signed-off-by: Akshay Gaikwad <akshay.gaikwad@rafay.co>
86f466b
to
a3bbeb3
Compare
Thanks @akshay196-rafay. From my side: /approve What do you think @gzcharleszhang or @richardchen331 ? |
@cpanato - in case you have some spare cycles to have a look and lgtm if you think its ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gzcharleszhang: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM. Thanks for the contribution @akshay196-rafay! |
@richardchen331: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much and sorry for the delay
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akshay196-rafay, cpanato, gzcharleszhang, richardcase, richardchen331 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @richardcase, @gzcharleszhang, @richardchen331 and @cpanato for reviewing and merging this. |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Support additional fields to GCPManagedMachinePool kind.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #906
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: