Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding e2e tests for gke (GKE Part 6) #844

Merged
merged 1 commit into from
Mar 10, 2023
Merged

test: adding e2e tests for gke (GKE Part 6) #844

merged 1 commit into from
Mar 10, 2023

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Feb 23, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This also makes the following changes to the existing merged GKE code:

  • InitialNodeCount has been made optional. If specified it will overwrite the Replicas values on the MachinePool (which defaults to 1)
  • The ProviderID logic for the GKE node group instances has been changed as it didn't work. We were using the instance resource url. As part of this a new providerid package has been created.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds e2e tests

Release note:

Adds e2e tests for GKE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2023
@cpanato
Copy link
Member

cpanato commented Feb 24, 2023

/test pull-cluster-api-provider-gcp-e2e-test

@richardcase richardcase mentioned this pull request Feb 28, 2023
Closed
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2023
@richardcase richardcase changed the title [WIP] test: adding e2e tests for gke (GKE Part 6 test: adding e2e tests for gke (GKE Part 6) Mar 7, 2023
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2023
@richardcase
Copy link
Member Author

As the GKE functionality hasn't been released we can ignore the apidiff errors:

/override pull-cluster-api-provider-gcp-apidiff

@k8s-ci-robot
Copy link
Contributor

@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-gcp-apidiff

In response to this:

As the GKE functionality hasn't been released we can ignore the apidiff errors:

/override pull-cluster-api-provider-gcp-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

richardchen331
richardchen331 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@richardchen331 richardchen331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good to me. Left only 2 minor comments.

exp/controllers/gcpmanagedcluster_controller.go Outdated Show resolved Hide resolved
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

@richardchen331: changing LGTM is restricted to collaborators

In response to this:

Thanks for the PR! It looks good to me. Left only 2 minor comments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato
cpanato reviewed Mar 8, 2023
View reviewed changes
test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@richardcase
feat: changes to for gke e2e testing
7211b96 
Adds GKE e2e tests. These tests will need to be expanded over time. Adds
a result of adding these tests various other changes where made
including:

- Adding docs about the permissions required
- Removed initial node count of the AWSManagedMachinePool
- Added validation to error if replicas isn't a multiple of 3 for a
region based cluster (which all gke clusters are initially)

Signed-off-by: Richard Case <richard.case@suse.com>
@richardcase
Copy link
Member Author

/override pull-cluster-api-provider-gcp-apidiff

@k8s-ci-robot
Copy link
Contributor

@richardcase: Overrode contexts on behalf of richardcase: pull-cluster-api-provider-gcp-apidiff

In response to this:

/override pull-cluster-api-provider-gcp-apidiff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardchen331
Copy link
Contributor

lgtm! @cpanato can take another look as well :)

cpanato
cpanato approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool
thanks
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, richardcase, richardchen331

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16261b9 into kubernetes-sigs:main Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardchen331 richardchen331 richardchen331 approved these changes

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@richardcase @cpanato @k8s-ci-robot @richardchen331