Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use local-ssd disk type #786

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Allow to use local-ssd disk type #786

merged 1 commit into from
Dec 15, 2022

Conversation

silenteh
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #768

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

- Fixes a bug preventing local-ssd disks from being used.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @silenteh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2022
@silenteh silenteh mentioned this pull request Dec 14, 2022
Closed
@richardcase
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 14, 2022
@dims
Copy link
Member

dims commented Dec 14, 2022

/retest

@dims
Copy link
Member

dims commented Dec 14, 2022 

Running [/home/runner/golangci-lint-1.50.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: File is not `gci`-ed with --skip-generated -s standard,default (gci)
  Error: Comment should end in a period (godot)
  Error: unnecessary leading newline (whitespace)
  Error: unnecessary trailing newline (whitespace)
  
  level=warning msg="[linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649."
  
  Error: issues found
  Ran golangci-lint in 144[23](https://github.com/kubernetes-sigs/cluster-api-provider-gcp/actions/runs/3693383985/jobs/6257558870#step:4:25)5ms

@richardcase
Copy link
Member

Thanks for this @silenteh. Would you be able to squash your commits?

@fiunchinho
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@fiunchinho: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@silenteh
Copy link
Contributor Author

Thanks for this @silenteh. Would you be able to squash your commits?

Sure - I am just struggling to run the golangci-lint locally to check if all lint pass. Then I will squash the commits.

@richardcase
Copy link
Member

Sure - I am just struggling to run the golangci-lint locally to check if all lint pass. Then I will squash the commits.

Thanks @silenteh 🙇 What issues are you getting when running the linter locally? Feel free to ping me on slack if you need another pair of eyes.

@silenteh
Copy link
Contributor Author

Sure - I am just struggling to run the golangci-lint locally to check if all lint pass. Then I will squash the commits.

Thanks @silenteh 🙇 What issues are you getting when running the linter locally? Feel free to ping me on slack if you need another pair of eyes.

I am getting the following error:

can't run linter goanalysis_metalinter: goimports: can't extract issues from gofmt diff output

I believe it's an issue in my local dev environment. Probably something to do with goimports and go-diff interoperability

@richardcase
Copy link
Member

I believe it's an issue in my local dev environment. Probably something to do with goimports and go-diff interoperability

I had a similar issue which was caused by the version of diff on my machine. To fix it i did:

brew install diffutils

@silenteh
allow to use local-ssk disk type
28f0044 
fixed linting

adding dots on comments

remove tracking of cluster-api-provider-gcp

allow to use local-ssk disk type
@silenteh
Copy link
Contributor Author

silenteh commented Dec 15, 2022 •
edited
Loading

I believe it's an issue in my local dev environment. Probably something to do with goimports and go-diff interoperability

I had a similar issue which was caused by the version of diff on my machine. To fix it i did:

brew install diffutils

Yep that was the issue.
Seems to be caused by the default diff command shipped with Apple, which can't parse the timezone on dates.
https://github.com/golangci/golangci-lint/issues/3087

Anyway...all linted and squashed.

@richardcase
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@richardcase: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-gcp-build
  • /test pull-cluster-api-provider-gcp-e2e-test
  • /test pull-cluster-api-provider-gcp-make
  • /test pull-cluster-api-provider-gcp-test
  • /test pull-cluster-api-provider-gcp-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-gcp-apidiff
  • /test pull-cluster-api-provider-gcp-capi-e2e
  • /test pull-cluster-api-provider-gcp-conformance
  • /test pull-cluster-api-provider-gcp-conformance-ci-artifacts
  • /test pull-cluster-api-provider-gcp-coverage
  • /test pull-cluster-api-provider-gcp-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-gcp-apidiff
  • pull-cluster-api-provider-gcp-build
  • pull-cluster-api-provider-gcp-e2e-test
  • pull-cluster-api-provider-gcp-make
  • pull-cluster-api-provider-gcp-test
  • pull-cluster-api-provider-gcp-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardcase
Copy link
Member

/test pull-cluster-api-provider-gcp-capi-e2e

@richardcase
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase, silenteh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 55bcb25 into kubernetes-sigs:main Dec 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiunchinho fiunchinho fiunchinho left review comments

@cpanato cpanato Awaiting requested review from cpanato

@dims dims Awaiting requested review from dims

Assignees

@richardcase richardcase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Invalid equality prevents the usage of local-ssd disks
5 participants
@silenteh @k8s-ci-robot @richardcase @dims @fiunchinho