Add proposal and scaffolding for managed Kubernetes in CAPG

[richardchen331]

/kind documentation

What this PR does / why we need it:
Add proposal and scaffolding for managed Kubernetes in CAPG (#512)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

- Add proposal for managed Kubernetes in CAPG
- Add scaffolds for managed Kubernetes in CAPG and defines the API types

[k8s-ci-robot]

Welcome @richardchen331!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @richardchen331. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cpanato]

/assign @richardcase @cpanato @pydctw

[richardcase]

Thanks for creating this @richardchen331

For @cpanato & @pydctw - myself & @richardchen331 have added a task list to the GKE issue, #512 , based on this proposal. We thought we'd proceed with implementation and then refactor based on any feedback from the proposal as needed as we go along.....just to speed things up.

[richardcase]

/ok-to-test

[richardchen331]

@cpanato The PR is rebased. Could you help review it when you get chance? Thanks! cc @richardcase

[richardcase]

This looks good to me.....it's worth calling out that this is the basis for the other open PRs and all the code here will not be used until a later PR uses and enables the GKE functionality.

@richardchen331 - a couple of very minor comments:

• The release note should probably be updated to include the fact that this also scaffolds the projects and defines the API types
• Do you think it's possible to squash some of the commits? We don't have to squash to 1 commit, but for instance the last 2 could be squashed.

[richardchen331]

This looks good to me.....it's worth calling out that this is the basis for the other open PRs and all the code here will not be used until a later PR uses and enables the GKE functionality.

@richardchen331 - a couple of very minor comments:

• The release note should probably be updated to include the fact that this also scaffolds the projects and defines the API types
• Do you think it's possible to squash some of the commits? We don't have to squash to 1 commit, but for instance the last 2 could be squashed.

Sounds good. I've updated the release note and squash the commits (2 left, 1 for the proposal, 1 for the scaffolds). Please let me know if you have other feedback :)

[cpanato]

lgtm as well, can we plan as a follow up to have some tests for that?

[richardcase]

lgtm as well, can we plan as a follow up to have some tests for that?

@cpanato - yes for sure 👍 Before we allow enabling of the controllers (via feature flag) we will make sure we have tests in place (unit and e2e).

[richardcase]

@richardchen331 - theres one small lint error:

Error: File is not `goimports`-ed (goimports)

Any chance you'd be able to take a look at that? Then i think we can merge 🎉

[cpanato]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, richardchen331

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[richardchen331]

@cpanato @richardcase I created another PR with only the proposal (#801), could you help review and approve it? I think I'll be able to run the lint test myself after that without asking you to run it every time :) Thanks!

[richardcase]

@cpanato @richardcase I created another PR with only the proposal (#801), could you help review and approve it? I think I'll be able to run the lint test myself after that without asking you to run it every time :) Thanks!

Ah yes, as you won't be a first-time contributor.

[cpanato]

/test all

[richardcase]

Thanks @cpanato 🧙

/lgtm