Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to reuse images explicitly #221

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Add option to reuse images explicitly #221

merged 1 commit into from
Oct 16, 2019

Conversation

dims
Copy link
Member

@dims dims commented Oct 16, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2019
@dims dims changed the title Add option to reuse images explicitly [WIP] Add option to reuse images explicitly Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2019
@dims dims force-pushed the option-to-skip-or-reuse-existing-images branch from 1ff9784 to 7e84282 Compare October 16, 2019 12:46
@dims dims changed the title [WIP] Add option to reuse images explicitly Add option to reuse images explicitly Oct 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2019
@dims
Copy link
Member Author

dims commented Oct 16, 2019

/assign @detiber @vincepri

Almost there with the ci-cluster-api-provider-gcp-make-conformance-stable-k8s-ci-artifacts job! this PR helps force build of fresh images unless overridden (as i am picking old images with 1.2.x containerd). We also cleanup after.

At some point we need to publish "stable" images and use them. At this moment, we have to rebuild stuff everytime.

vincepri
vincepri approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit a70518c into kubernetes-sigs:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@krousey krousey Awaiting requested review from krousey

Assignees

@detiber detiber

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @k8s-ci-robot @vincepri @detiber