-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new network for us to use, still allow default to work #192
Create a new network for us to use, still allow default to work #192
Conversation
ce35f68
to
174a3f1
Compare
/test pull-cluster-api-provider-gcp-make-conformance |
1 similar comment
/test pull-cluster-api-provider-gcp-make-conformance |
/test pull-cluster-api-provider-gcp-make-conformane |
@dims are there perhaps reasons why some testing might prefer to be run against legacy networks? Should we instead test for legacy network and attempt to checkout another GCE account instead? |
/test pull-cluster-api-provider-gcp-make-conformance |
@detiber have to ask folks in sig-testing on why we have a mix of these. Since the gcp-janitor seems to remove all networks and firewalls, i was trying to see if these are remnants of a bad gcp janitor run as well. (and see if we could clean these and reuse them) |
/test pull-cluster-api-provider-gcp-make-conforman |
/test pull-cluster-api-provider-gcp-make-conformance |
4 similar comments
/test pull-cluster-api-provider-gcp-make-conformance |
/test pull-cluster-api-provider-gcp-make-conformance |
/test pull-cluster-api-provider-gcp-make-conformance |
/test pull-cluster-api-provider-gcp-make-conformance |
Instead of modifying the default network, what if we create a brand new one and delete it at the end? |
@vincepri good point! |
7578749
to
7fffe0c
Compare
d666e36
to
cba1fc8
Compare
/close |
@dims: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@dims: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0573aa5
to
93bd621
Compare
Some of the boskos projects are "Legacy" and functionality like NATS is not available there. So let's just create our own and clean it up when we exit Change-Id: Ia1438ba496707680309ff645962b4295439dc977
7e46ff0
to
04ce339
Compare
/test pull-cluster-api-provider-gcp-make-conformance |
@dims: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change-Id: Ia1438ba496707680309ff645962b4295439dc977
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #