Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new network for us to use, still allow default to work #192

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Create a new network for us to use, still allow default to work #192

merged 2 commits into from
Oct 2, 2019

Conversation

dims
Copy link
Member

@dims dims commented Oct 1, 2019

Change-Id: Ia1438ba496707680309ff645962b4295439dc977

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2019
@dims dims force-pushed the switch-network-from-legacy-to-auto-mode branch from ce35f68 to 174a3f1 Compare October 1, 2019 12:27
@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

1 similar comment
@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformane

@detiber
Copy link
Member

detiber commented Oct 1, 2019

@dims are there perhaps reasons why some testing might prefer to be run against legacy networks? Should we instead test for legacy network and attempt to checkout another GCE account instead?

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@dims
Copy link
Member Author

dims commented Oct 1, 2019

@detiber have to ask folks in sig-testing on why we have a mix of these. Since the gcp-janitor seems to remove all networks and firewalls, i was trying to see if these are remnants of a bad gcp janitor run as well. (and see if we could clean these and reuse them)

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conforman

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

4 similar comments
@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@vincepri
Copy link
Member

vincepri commented Oct 1, 2019

Instead of modifying the default network, what if we create a brand new one and delete it at the end?

@dims
Copy link
Member Author

dims commented Oct 1, 2019

@vincepri good point!

@dims dims force-pushed the switch-network-from-legacy-to-auto-mode branch 2 times, most recently from 7578749 to 7fffe0c Compare October 1, 2019 14:42
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2019
@dims dims force-pushed the switch-network-from-legacy-to-auto-mode branch 2 times, most recently from d666e36 to cba1fc8 Compare October 1, 2019 18:41
@dims
Copy link
Member Author

dims commented Oct 1, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member Author

dims commented Oct 1, 2019

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

@dims: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims dims changed the title [WIP] 🐛Switch default network from Legacy to Auto if needed Create a new network for us to use, still allow default to work Oct 1, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2019
@dims dims force-pushed the switch-network-from-legacy-to-auto-mode branch from 0573aa5 to 93bd621 Compare October 1, 2019 22:08
@dims
Avoid using the default network
0ec3e20 
Some of the boskos projects are "Legacy" and functionality like NATS is
not available there. So let's just create our own and clean it up when
we exit

Change-Id: Ia1438ba496707680309ff645962b4295439dc977
@dims
things change!
04ce339
@dims dims force-pushed the switch-network-from-legacy-to-auto-mode branch from 7e46ff0 to 04ce339 Compare October 1, 2019 23:41
@dims
Copy link
Member Author

dims commented Oct 2, 2019

/test pull-cluster-api-provider-gcp-make-conformance

@k8s-ci-robot
Copy link
Contributor

@dims: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-gcp-make-conformance 04ce339 link /test pull-cluster-api-provider-gcp-make-conformance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vincepri
vincepri approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit e202103 into kubernetes-sigs:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @detiber @vincepri @k8s-ci-robot