Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Labels on Disks and ForwardingRules resources #1275

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Set Labels on Disks and ForwardingRules resources #1275

merged 1 commit into from
Jun 28, 2024

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented Jun 27, 2024 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

The Labels field should be set on Disks and ForwardingRules resources from the machine or cluster AdditionalLabels field, similar to how it is set on Instances.

Fixes #1274

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

This fix populates the Disk and ForwardingRules resources' `Labels` field from the machine/cluster `AdditionalLabels` field.

@bfournie
Set Labels on Disks and ForwardingRules resources
9112c32 
The Labels field should be set on Disks and ForwardingRules resources
from the machine or cluster AdditionalLabels field, similar to how it is
set on Instances.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bfournie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 9112c32
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/667dc3b97f109d000878d779
😎 Deploy Preview https://deploy-preview-1275--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cpanato
cpanato reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 28, 2024
cpanato
cpanato approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3c2e7de into kubernetes-sigs:main Jun 28, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Jun 28, 2024
@bfournie bfournie deleted the additonal-labels branch June 28, 2024 11:08
@bfournie bfournie mentioned this pull request Jun 28, 2024
Closed
bfournie added a commit to bfournie/installer that referenced this pull request Jul 26, 2024
@bfournie
WIP: Upgrade to latest cluster-api-provider-gcp
677cca6 
This picks up fix for shared VPC and labels, particularly:
kubernetes-sigs/cluster-api-provider-gcp#1280
kubernetes-sigs/cluster-api-provider-gcp#1277
kubernetes-sigs/cluster-api-provider-gcp#1275
@bfournie bfournie mentioned this pull request Jul 26, 2024
Merged
bfournie added a commit to bfournie/installer that referenced this pull request Jul 29, 2024
@bfournie
WIP: Upgrade to latest cluster-api-provider-gcp
7fd0d3e 
This picks up fix for shared VPC and labels, particularly:
kubernetes-sigs/cluster-api-provider-gcp#1280
kubernetes-sigs/cluster-api-provider-gcp#1277
kubernetes-sigs/cluster-api-provider-gcp#1275
bfournie added a commit to bfournie/installer that referenced this pull request Jul 30, 2024
@bfournie
WIP: Upgrade to latest cluster-api-provider-gcp
94f312b 
This picks up fix for shared VPC and labels, particularly:
kubernetes-sigs/cluster-api-provider-gcp#1280
kubernetes-sigs/cluster-api-provider-gcp#1277
kubernetes-sigs/cluster-api-provider-gcp#1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@damdo damdo Awaiting requested review from damdo

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

AdditionalLabels are not added to all GCP resources
3 participants
@bfournie @k8s-ci-robot @cpanato