Skip to content

Commit

Permalink
feat: improve compareMasterAuthorizedNetworksConfig
Browse files Browse the repository at this point in the history
  • Loading branch information
FrancoisKlieberOrange authored and francois.klieber.ext@orange.com committed Jul 25, 2024
1 parent 7623103 commit f97bc9a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cloud/services/container/clusters/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"cloud.google.com/go/container/apiv1/containerpb"
"github.com/go-logr/logr"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"github.com/googleapis/gax-go/v2/apierror"
"github.com/pkg/errors"
"google.golang.org/grpc/codes"
Expand Down Expand Up @@ -473,7 +474,7 @@ func compareMasterAuthorizedNetworksConfig(a, b *containerpb.MasterAuthorizedNet
if (a.CidrBlocks == nil && b.CidrBlocks != nil && len(b.GetCidrBlocks()) == 0) || (b.CidrBlocks == nil && a.CidrBlocks != nil && len(a.GetCidrBlocks()) == 0) {
return true
}
if !cmp.Equal(a.GetCidrBlocks(), b.GetCidrBlocks()) {
if !cmp.Equal(a.GetCidrBlocks(), b.GetCidrBlocks(), cmpopts.IgnoreUnexported(containerpb.MasterAuthorizedNetworksConfig_CidrBlock{})) {
return false
}
return true
Expand Down

0 comments on commit f97bc9a

Please sign in to comment.