Skip to content

Commit

Permalink
fix lints
Browse files Browse the repository at this point in the history
Signed-off-by: cpanato <ctadeu@gmail.com>
  • Loading branch information
cpanato committed May 16, 2024
1 parent 94f22b1 commit bf05c4d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cloud/providerid/providerid_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func TestProviderID_New(t *testing.T) {
}

for _, tc := range testCases {
t.Run(tc.testname, func(t *testing.T) {
t.Run(tc.testname, func(_ *testing.T) {
providerID, err := providerid.New(tc.project, tc.location, tc.name)

if tc.expectError {
Expand Down Expand Up @@ -102,7 +102,7 @@ func TestProviderID_NewFromResourceURL(t *testing.T) {
}

for _, tc := range testCases {
t.Run(tc.testname, func(t *testing.T) {
t.Run(tc.testname, func(_ *testing.T) {
providerID, err := providerid.NewFromResourceURL(tc.resourceURL)

if tc.expectError {
Expand Down
2 changes: 1 addition & 1 deletion cloud/services/compute/instances/reconcile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func TestService_createOrGetInstance(t *testing.T) {
mockInstance: &cloud.MockInstances{
ProjectRouter: &cloud.SingleProjectRouter{ID: "proj-id"},
Objects: map[meta.Key]*cloud.MockInstancesObj{},
GetHook: func(ctx context.Context, key *meta.Key, m *cloud.MockInstances, _ ...cloud.Option) (bool, *compute.Instance, error) {
GetHook: func(_ context.Context, _ *meta.Key, _ *cloud.MockInstances, _ ...cloud.Option) (bool, *compute.Instance, error) {
return true, &compute.Instance{}, &googleapi.Error{Code: http.StatusBadRequest}
},
},
Expand Down
2 changes: 1 addition & 1 deletion cloud/services/compute/subnets/reconcile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func TestService_Reconcile(t *testing.T) {
mockSubnetworks: &cloud.MockSubnetworks{
ProjectRouter: &cloud.SingleProjectRouter{ID: "my-proj"},
Objects: map[meta.Key]*cloud.MockSubnetworksObj{},
GetHook: func(ctx context.Context, key *meta.Key, m *cloud.MockSubnetworks, _ ...cloud.Option) (bool, *compute.Subnetwork, error) {
GetHook: func(_ context.Context, _ *meta.Key, _ *cloud.MockSubnetworks, _ ...cloud.Option) (bool, *compute.Subnetwork, error) {
return true, &compute.Subnetwork{}, &googleapi.Error{Code: http.StatusBadRequest}
},
},
Expand Down
2 changes: 1 addition & 1 deletion exp/controllers/gcpmanagedmachinepool_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func GetOwnerClusterKey(obj metav1.ObjectMeta) (*client.ObjectKey, error) {
}

func machinePoolToInfrastructureMapFunc(gvk schema.GroupVersionKind) handler.MapFunc {
return func(ctx context.Context, o client.Object) []reconcile.Request {
return func(_ context.Context, o client.Object) []reconcile.Request {
m, ok := o.(*expclusterv1.MachinePool)
if !ok {
panic(fmt.Sprintf("Expected a MachinePool but got a %T", o))
Expand Down

0 comments on commit bf05c4d

Please sign in to comment.