🐛 Remove Helm condition for AWS VPC CNI deletion

[jas-nik]

What type of PR is this?
/kind bug

What this PR does / why we need it:

Recently, AWS changed the way VPC CNI is installed from manifest apply to managing it via Helm (ref: aws/amazon-vpc-cni-k8s#2763 (comment)). This makes AWSManagedControlPlane.Spec.VpcCni.Disable flag obsolete due to the app.kubernetes.io/managed-by: Helm condition in deleteCNI flow.

This PR removes that condition to make the flag functional.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # 4743

Special notes for your reviewer:

For users replacing the default VPC CNI with their own helm-managed VPC CNI - They will need to set AWSManagedControlPlane.Spec.VpcCni.Disable to false (default) OR set label on VPC CNI resource "prevent-deletion": "true"

Checklist:

• squashed commits
• includes documentation
• includes emojis
• adds unit tests
• adds or updates e2e tests

Release note:

Flag to remove the default Helm-managed AWS VPC CNI EKS Addon

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jas-nik / name: Jaswanth V (02198d3)

[k8s-ci-robot]

Welcome @jas-nik!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jas-nik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jas-nik]

/assign @nrb @richardcase

[nrb]

/ok-to-test

[jas-nik]

@richardcase - Done. Added a label prevent-deletion, please review when you get a chance.

[richardcase]

/milestone v2.6.0

[cnmcavoy]

/lgtm

We probably need to document the label in the future.

[richardcase]

We probably need to document the label in the future.

Thats a good point @cnmcavoy . I think we should probably include documentation with this PR. wdyt @jas-nik @cnmcavoy ?

[jas-nik]

Updated pod networking doc

[AndiDog]

Minor wording comments, otherwise

/lgtm

[richardcase]

@jas-nik - thanks for the updates. Could you resolve the 2 open items and then i think we are good to go. Thank you so much for this.

[jas-nik]

/retest

[richardcase]

There was previous lgtm (and only a comment change) so:

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardcase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment