Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump CAPI to v1.7.0 #4897

Merged
merged 1 commit into from
Apr 18, 2024
Merged

🌱 Bump CAPI to v1.7.0 #4897

merged 1 commit into from
Apr 18, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented Mar 27, 2024 •
edited
Loading

What type of PR is this?
/kind support

What this PR does / why we need it:

CAPI v1.7.0 is out now, so this PRs bumps the CAPI version used by CAPG with the new released one.

Bumps CAPI to v1.7.x based on https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/developer/providers/migrations/v1.6-to-v1.7.md

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes emojis
  • adds or updates e2e tests

Release note:

Bump CAPI to v1.7.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2024
@damdo damdo mentioned this pull request Mar 27, 2024
Closed
@damdo damdo changed the title ✨ WIP: Bump CAPI to v1.7 ✨ WIP: Bump CAPI to v1.7.x Mar 27, 2024
@damdo
Copy link
Member Author

damdo commented Mar 27, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@nrb
Copy link
Contributor

nrb commented Mar 28, 2024

/retitle 🌱 WIP: Bump CAPI to v1.7.x

@k8s-ci-robot k8s-ci-robot changed the title ✨ WIP: Bump CAPI to v1.7.x 🌱 WIP: Bump CAPI to v1.7.x Mar 28, 2024
@damdo
Copy link
Member Author

damdo commented Apr 3, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@nrb nrb added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 3, 2024
@damdo damdo mentioned this pull request Apr 4, 2024
Merged
@damdo
Copy link
Member Author

damdo commented Apr 10, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@damdo damdo force-pushed the capi-1.7.0 branch 2 times, most recently from 5791212 to b981021 Compare April 10, 2024 13:10
@damdo
Copy link
Member Author

damdo commented Apr 10, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@damdo damdo changed the title 🌱 WIP: Bump CAPI to v1.7.x 🌱 Bump CAPI to v1.7.0 Apr 17, 2024
@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/assign @richardcase @dlipovetsky @nrb @Ankitasw @vincepri @AndiDog

@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/hold
until testing is completed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/test pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

Early timeout

/test pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/retest

@damdo
bump to capi v1.7.0
fc4fddb 
- bump deps for capi v1.7.x
- enable MachinePools by default
- use capi v1.7.0
@damdo
Copy link
Member Author

damdo commented Apr 17, 2024

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Apr 18, 2024

/unhold

Ready for labelling
cc. @richardcase

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@richardcase
Copy link
Member

Thanks @damdo . This looks good from my side and the e2e tests are passing so:

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit b918c36 into kubernetes-sigs:main Apr 18, 2024
21 checks passed
@r4f4 r4f4 mentioned this pull request Apr 19, 2024
Merged
5 tasks
fad3t pushed a commit to fad3t/cluster-api-provider-aws that referenced this pull request Jul 25, 2024
@damdo @fad3t
bump to capi v1.7.0 (kubernetes-sigs#4897)
b208617 
- bump deps for capi v1.7.x
- enable MachinePools by default
- use capi v1.7.0
fad3t pushed a commit to fad3t/cluster-api-provider-aws that referenced this pull request Oct 8, 2024
@damdo @fad3t
bump to capi v1.7.0 (kubernetes-sigs#4897)
a8d4494 
- bump deps for capi v1.7.x
- enable MachinePools by default
- use capi v1.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@vincepri vincepri

@dlipovetsky dlipovetsky

@Ankitasw Ankitasw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@damdo @nrb @richardcase @k8s-ci-robot @AndiDog @vincepri @dlipovetsky @Ankitasw