support dpdk #1317
Merged
support dpdk #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luoyunhe the |
ok, Could you give me some suggestions for this PR, thanks. |
|
@luoyunhe it looks good to me now. I will test the pr in my cluster later and will let you know if something need to change |
oilbeater
requested changes
Mar 11, 2022
docs/dpdk-hybrid.md
Outdated
| For other drivers, please refer to https://www.dpdk.org/ | ||
|
|
||
| ## configrue node | ||
| Edit the configuration file named ovs-dpdk-config on the node that needs to run ovs-dpdk. The configuration file needs to be placed in the /opt/ovs-config directory. |
There was a problem hiding this comment.
ovs-dpdk-config -> ovs-dpdk-config
/opt/ovs-config -> /opt/ovs-config
pkg/daemon/handler.go
Outdated
| } else if podRequest.VhostUserSocketVolumeName != "" { | ||
| nicType = util.DpdkType | ||
| err = createShortSharedDir(pod, podRequest.VhostUserSocketVolumeName) | ||
| if err != nil { |
There was a problem hiding this comment.
use if errr = xxx; err != nil {} error handle format
oilbeater
requested changes
Mar 11, 2022
oilbeater
approved these changes
Mar 11, 2022
|
Great work! Thanks @luoyunhe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Feature
run Kube-OVN with nodes which run ovs-dpdk or ovs-kernel