Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming in release artifacts #2183

Closed
2 tasks
texasmichelle opened this issue Dec 27, 2018 · 2 comments
Closed
2 tasks

Use consistent naming in release artifacts #2183

texasmichelle opened this issue Dec 27, 2018 · 2 comments

Comments

@texasmichelle
Copy link
Member

Consistently name release artifacts.

  • Add kubeflow- to archive name. This makes it easier to identify the source of the downloaded file.
  • Do not strip v from version in unpacked artifact. This is consistent with version tags in the repo.

Example:
Latest release asset is named v0.3.5, but unpacked folder is named kubeflow-0.3.5:

$ wget https://github.com/kubeflow/kubeflow/archive/v0.3.5.tar.gz
$ tar -xvf v0.3.5.tar.gz
$ ls
kubeflow-0.3.5
@jlewi
Copy link
Contributor

jlewi commented Dec 28, 2018

I'm not sure how much control we have here.

I think the name "v0.3.5" is based on the release tag.

The tarball is autogenerated from the source tree as well by GitHub.

@texasmichelle
Copy link
Member Author

Oh right - because we're not generating binaries, this is an automated GH thing. Consistency across all of GH makes it less of an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants