Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

[RFE] make control plane key configurable #462

Open
thoraxe opened this issue Nov 30, 2020 · 2 comments
Open

[RFE] make control plane key configurable #462

thoraxe opened this issue Nov 30, 2020 · 2 comments

Comments

@thoraxe
Copy link

thoraxe commented Nov 30, 2020

Currently, via #123 , a control-plane label is applied to namespaces where kubeflow is running. While this is well-intentioned (to prevent the application of kubeflow webhooks), it unfortunately causes collisions with other solutions.

This issue is a request for enhancement to make the key (control-plane) configurable.

An alternate suggestion would be to make the fixed key prefixed in some way. eg: kf-control-plane.

At this time, the control-plane label is causing an issue with knative serving deployments (no issue has been filed for that yet).

@slenky
Copy link

slenky commented Dec 2, 2020

Upvoting it.
In Azure that label also blocks Istio Injection for Kubeflow namespace because of Azure/AKS#1771
Whenever I use kfctl to apply some changes I need to remove the control-plane label from Kubeflow namespace and rollout restart all the deployments.

@berndverst
Copy link
Member

FYI @kubeflow/wg-manifests-leads

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants