Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support log-uniform scale in search space definition #1207

Open
gaocegege opened this issue Jun 5, 2020 · 12 comments
Open

[feature] Support log-uniform scale in search space definition #1207

gaocegege opened this issue Jun 5, 2020 · 12 comments

Comments

@gaocegege
Copy link
Member

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

#1205 (comment)

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.98

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@gaocegege
Copy link
Member Author

/cc @sperlingxx @andreyvelich

@sperlingxx
Copy link
Member

@gaocegege
In my opinion, we need to add additional field Distribution in FeasibleSpace. The FeasibleSpace definition could be changed to:

type ParameterDistribution string

const (
	Uniform    ParameterDistribution = "uniform"
	LogUniform ParameterDistribution = "log_uniform"
	Normal     ParameterDistribution = "normal"
	LogNormal  ParameterDistribution = "log_normal"
	Discrete   ParameterDistribution = "discrete"
)

type FeasibleSpace struct {
	Max          string                `json:"max,omitempty"`
	Min          string                `json:"min,omitempty"`
	List         []string              `json:"list,omitempty"`
	Step         string                `json:"step,omitempty"`
	Distribution ParameterDistribution `json:"distribution,omitempty"`
}

@gaocegege
Copy link
Member Author

SGTM. I think it is one possible approach.

@stale
Copy link

stale bot commented Nov 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/lifecycle frozen

@tenzen-y
Copy link
Member

tenzen-y commented Dec 2, 2022

/assign

I will submit a small proposal for this feature.

@yanwu2014
Copy link

Any updates on this? Would love to be able to search over a log-uniform scale for tuning learning rates

@tenzen-y
Copy link
Member

[WIP] Add enhancement for Parameter Distribution #2059

@yanwu2014 Thank you for being interested in this feature. I'm writing the proposal. But we need to cut a new Experiment API version (v1beta2) since we need to introduce significant and breaking changes.

So it will take a little bit of time to release.

@yanwu2014
Copy link

That's great, thanks so much :)!

@andreyvelich
Copy link
Member

/area gsoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants