Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EdgeApplication image path annotation error #4867

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

tangming1996
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
An incorrect image path will result in a failure to create a deployment instance.
Which issue(s) this PR fixes:
The deployment instance could not be created due to a image path error.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kubeedge-bot kubeedge-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 23, 2023
@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2023
Signed-off-by: ming.tang <ming.tang@daocloud.io>
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2023
@tangming1996 tangming1996 reopened this Jul 23, 2023
@fisherxu
Copy link
Member

/assign @ZhengXinwei-F

@kubeedge-bot
Copy link
Collaborator

@fisherxu: GitHub didn't allow me to assign the following users: zhengxinwei-F.

Note that only kubeedge members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ZhengXinwei-F

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the yaml under build and manifest dir should be auto-generated? @tangming1996

@tangming1996
Copy link
Contributor Author

LGTM,构建和清单目录下的yaml应该是自动生成的?@tangming1996

Yes, it is automatically generated using the kubeedge CRD script

Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2023
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2023
@kubeedge-bot kubeedge-bot merged commit 3bf5a4b into kubeedge:master Jul 29, 2023
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants