-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EdgeApplication image path annotation error #4867
Fix EdgeApplication image path annotation error #4867
Conversation
efa2c99
to
2f97073
Compare
Signed-off-by: ming.tang <ming.tang@daocloud.io>
2f97073
to
37f146d
Compare
/assign @ZhengXinwei-F |
@fisherxu: GitHub didn't allow me to assign the following users: zhengxinwei-F. Note that only kubeedge members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the yaml under build and manifest dir should be auto-generated? @tangming1996
Yes, it is automatically generated using the kubeedge CRD script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
An incorrect image path will result in a failure to create a deployment instance.
Which issue(s) this PR fixes:
The deployment instance could not be created due to a image path error.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: